Repository navigation
Fix field width handling in enum stream output - #480
Open
davidscottpope-gif wants to merge 7 commits into
Open
davidscottpope-gif wants to merge 7 commits into
davidscottpope-gif wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The width bug lives in the two named-value loops in magic_enum_iostream.hpp; optional output, the iostream alias and the module export inherit it. Insert each name as one formatted string field so width applies and resets, as merged #479 already does for bitset.
We also tried a sentry-aware mixed-character writer, but its hand-written streambuf handling diverged on libc++, swallowed forced unwind and leaked tied-stream exceptions, so this patch delegates to native string insertion. Mixed-character output can allocate before the sentry check; same-character output uses string_view without a conversion allocation.
Tests cover width/alignment/fill, flags, optional values, wide/custom-Traits/alias output, short writes, exceptions, ties and unitbuf. AI-assisted investigation and reproduction.