dashboard: cleanup table navigation and implement pagination on the remaining screens #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation makes table navigation easier to implement in new screens and also more consistent, in a single place and not repeated in many screens, also supports pagination (pgup/pgdown)
…for table navigation also adds pagination to pages that did not support it before
aszepieniec
reviewed
Nov 18, 2025
Contributor
aszepieniec
left a comment
aszepieniec
left a comment
There was a problem hiding this comment.
Excellent PR, excellent work -- not least because of 
!
I reviewed the code changes and they look good to me. I would merge but I did notice two strange behaviors that I would like to poke your brain about first. Maybe they are a very small change away from being fixed.
- Something weird happens in the Peers screen when the terminal window is only 6 rows high. The table header is being rendered over the canvas borders.
- The table on the Mempool screen is not scrollable. Is that by design? (I ask because in the future we might want more fine-grained control over individual transactions in the mempool with commands like "upgrade now" or "bump in priority" or "(re-)broadcast".)
Contributor
Author
I see it, same seems to happen on the master branch, could it be because of the label that shows the number of peers connected? It's the only screen with a label like that, and other table-screens render just fine on that size, I'll have a deeper look on the _layout math_ tomorrow
once solved I'll include both as commits to this PR |
Contributor
|
@imalfect: Are you still working on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new
scrollable_table.rsfile which contains utility functions that implement table pagination and navigation. Table navigation logic in screens was replaced with it, which reduces code duplication. On top of that, it also adds the pagination feature (which was recently implemented in the peers screen) to other screens that have interactive tables.