Run tests on wasm32 architecture #269
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the necessary Cargo.toml magic for `cargo test` to build tests correctly, both #[test] and #[proptest]. However the wasm test harness ignores #[test] and #[proptest] so tests are not actually run in that environment. The source files will need to be modified to make the tests visible to wasm test harness in a future commit.
annotates tests to indicate they should be compiled for wasm32 target by decorating with #[wasm_bindgen_test] when target_arch = wasm32.
It remains 32 on 64 bit systems. This avoids isize::MAX overflow for 32 bit systems and fixes a failing test case
Relies on test-strategy version strictly greater than v0.4.1. Intended as a fixup for commit “test: tests run in wasm32 test harness”
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convince all dependencies and tests that they should run on
wasm32architectures.TODO
proptest-arbitrary-interopto play ball, ideally through add support for building wasm32 target graydon/proptest-arbitrary-interop#3#[test]annotations into#[macro_rules_attr::apply(test)](see corresponding WIP commit)wasm32-unknown-unknowntargetREADME-wasm32.mdin README? Link to it? …?Supersedes #265.