Open
Conversation
Andyz26
reviewed
Mar 29, 2026
Andyz26
reviewed
Mar 29, 2026
b252107 to
54080a3
Compare
Andyz26
reviewed
Mar 29, 2026
|
|
||
| if (noResourcesAvailable) { | ||
| log.warn("Not all scheduling constraints had enough workers available to fulfill the request {}", request); | ||
| log.warn("Not all scheduling constraints had enough workers for jobId={}, cluster={}", |
Collaborator
There was a problem hiding this comment.
i think you still need workerId + schedulingConstraint info
Collaborator
Author
There was a problem hiding this comment.
worker id and constraint info already logged at findTaskExecutorsFor before coming into this log line.
I can put constraint again in this log line.
worker id we can't output here because it's in the array nested fields.
Collaborator
There was a problem hiding this comment.
maybe include the reservation instance too? could make search easier
james-lubin
approved these changes
Mar 30, 2026
54080a3 to
1c324d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
currently logs are way too long to read, it basically just saying we don't have enough worker to fulfill the request that request for one single worker, and we don't need all these
machineDefinition=MachineDefinition{cpuCores=2.0, memoryMB=14336.0, networkMbps=700.0, diskMB=65536.0, numPorts=1to be part of the details.Besides, we don't have logs to explain why we can't find the TE for the worker even though the scheduler sees there are 2 idle TE, adding logs to show details why TE not selected for the worker
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests