Skip to content

Fix noisy retry when noResourceError with rev based scheduling#844

Open
hellolittlej wants to merge 1 commit intomasterfrom
noisy-logs
Open

Fix noisy retry when noResourceError with rev based scheduling#844
hellolittlej wants to merge 1 commit intomasterfrom
noisy-logs

Conversation

@hellolittlej
Copy link
Copy Markdown
Collaborator

Context

  • The inflightReservationRequest retried every 5s for no resource Error, previous it used to be 1 minute with master scheduling schedule.
  • add the delay for scaling operation

Explain context and other details for this pull request.

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Test Results

159 files   -  3  159 suites   - 3   10m 59s ⏱️ +51s
696 tests  - 85  687 ✅  - 83  7 💤  - 4  2 ❌ +2 
697 runs   - 84  687 ✅  - 83  7 💤  - 4  3 ❌ +3 

For more details on these failures, see this check.

Results for commit 9cae359. ± Comparison against base commit b9bc562.

This pull request removes 85 tests.
io.mantisrx.master.jobcluster.JobClusterAkkaTest ‑ testCreateAddAndDeleteRules
io.mantisrx.master.jobcluster.JobClusterAkkaTest ‑ testCreateScalerRuleFromEmpty
io.mantisrx.master.jobcluster.JobClusterAkkaTest ‑ testCronTriggersSLAToKillOld
io.mantisrx.master.jobcluster.JobClusterAkkaTest ‑ testDeleteScalerRule
io.mantisrx.master.jobcluster.JobClusterAkkaTest ‑ testExpireOldJobs
io.mantisrx.master.jobcluster.JobClusterAkkaTest ‑ testGetJobDetailsForArchivedJob
io.mantisrx.master.jobcluster.JobClusterAkkaTest ‑ testGetLastSubmittedJob
io.mantisrx.master.jobcluster.JobClusterAkkaTest ‑ testGetLastSubmittedJobSubject
io.mantisrx.master.jobcluster.JobClusterAkkaTest ‑ testGetLastSubmittedJobSubjectWithWrongClusterNameFails
io.mantisrx.master.jobcluster.JobClusterAkkaTest ‑ testGetLastSubmittedJobWithCompletedOnly
…

♻️ This comment has been updated with latest results.

Comment on lines +482 to +484
inFlightReservationRequestTimestamps.put(
exceptionConstraintKey,
clock.instant().plus(DEFAULT_NO_RESOURCE_EXTRA_DELAY));
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is inFlightReservationRequestTimestamps only used so that shouldSkipConstraintGroup can make its determination? If we add metrics/logs based on the values in inFlightReservationRequestTimestamps, this could get confusing. I wonder if we should add this handling within shouldSkipConstraintGroup instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants