fix: extract-image regression #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concurrent node/add-module actions fail on flock acquiring the lock file. The lock file is created in a unique path by node/add-module, preventing the execution of multiple modules installation at the same time, which normally happens in cluster/create-cluster and cluster/add-node actions. This commit changes extract-image behavior. The lock file is created under ./ (the working directory) instead of AGENT_INSTALL_DIR/.
gsanchietti
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concurrent node/add-module actions fail on flock acquiring the lock file.
The lock file is created in a unique path by node/add-module, preventing the execution of multiple modules installation at the same time, which normally happens in cluster/create-cluster and cluster/add-node actions.
This commit changes extract-image behavior. The lock file is created under ./ (the working directory) instead of AGENT_INSTALL_DIR/.
Refs NethServer/dev#7058