Skip to content

fix: broken forced remove-module #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

fix: broken forced remove-module #799

merged 1 commit into from
Feb 18, 2025

Conversation

@DavidePrincipi
Copy link
Member

@DavidePrincipi DavidePrincipi commented Feb 10, 2025 •
edited
Loading

Avoid premature step termination for sys.exit(2) invoked by agent.assert_exp(). The forced exit happens before the code that ignores the error.

Feb 10 15:25:39 ns8 agent@cluster[1114668]: task/cluster/5b8815fa-3309-4432-9044-5b4ce0b3f7c4: remove-module/50update is starting
Feb 10 15:25:54 ns8 agent@cluster[1114668]: Assertion failed
Feb 10 15:25:54 ns8 agent@cluster[1114668]:   File "/var/lib/nethserver/cluster/actions/remove-module/50update", line 66, in <module>
Feb 10 15:25:54 ns8 agent@cluster[1114668]:     agent.assert_exp(destroy_module_result['exit_code'] == 0)
Feb 10 15:25:54 ns8 agent@cluster[1114668]: task/cluster/5b8815fa-3309-4432-9044-5b4ce0b3f7c4: action "remove-module" status is "aborted" (2) at step 50update

Note exit code (2) and the "Assertion failed": the proof of agent.assert_exp() invocation.

@DavidePrincipi
fix: broken forced remove-module
9fb7bcd 
Avoid premature step termination for sys.exit(2) invoked by agent.assert_exp(). The forced exit happens before the code that ignores the error.
@DavidePrincipi DavidePrincipi added the testing Start test suite label Feb 10, 2025
@DavidePrincipi DavidePrincipi self-assigned this Feb 10, 2025
@DavidePrincipi DavidePrincipi merged commit fdda107 into main Feb 18, 2025
5 of 8 checks passed
@DavidePrincipi DavidePrincipi deleted the fix-remove-module branch February 18, 2025 13:29
@DavidePrincipi
Copy link
Member Author

DavidePrincipi commented Feb 18, 2025

Released https://github.com/NethServer/ns8-core/releases/tag/3.4.6

gsanchietti pushed a commit that referenced this pull request Feb 26, 2025
@DavidePrincipi @gsanchietti
fix: broken forced remove-module (#799)
0177162 
Avoid premature step termination for sys.exit(2) invoked by agent.assert_exp(). The forced exit happens before the code that ignores the error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gsanchietti gsanchietti gsanchietti approved these changes

Assignees

@DavidePrincipi DavidePrincipi

Labels

testing Start test suite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DavidePrincipi @gsanchietti