spec(phase-8): add deployment tasks#7
Merged
Merged
Conversation
Adds the tasks.md companion to the phase-8-deployment spec, breaking the approved requirements + design into 44 dependency-ordered tasks across 9 batches (A-I): A Rate limiter module with memory backend default (6 tasks) B Sentry wiring behind SENTRY_DSN (5 tasks) C Auth fail-closed tightening + app-level PBT suite (2 tasks) D Railway manifests + runbook scripts (5 tasks) E .env.example + README docs (2 tasks) F External provisioning (Railway / Neon / Upstash / Sentry / GitHub / DNS) (8 tasks) G Staging cutover (6 tasks) H Production cutover (7 tasks) I Post-deploy cleanup (3 tasks) Each task cites its acceptance criteria by R-ID, lists the files touched per design section 2, declares its verification command, and names its dependencies so the spec-task-execution sub-agent can pick them up in order.
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".kiro/specs/phase-8-deployment/tasks.md">
<violation number="1" location=".kiro/specs/phase-8-deployment/tasks.md:311">
P2: H4’s dependency gating contradicts its own execution instructions: it says DNS may be flipped during H4, but requires F8 to be completed first. This makes the fallback path impossible in the task runner.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| - Preconditions: F8, H2. | ||
| - Acceptance criteria: R9.1, R9.2, R9.3, R9.4, R9.5. | ||
| - Verification: `dig api.stackfast.app +short` matches the Railway edge; `curl -I https://stackfast.app` returns 200; `curl -I http://stackfast.app` returns 301/308 to `https://stackfast.app`. | ||
| - Dependencies: F8, H2. |
There was a problem hiding this comment.
P2: H4’s dependency gating contradicts its own execution instructions: it says DNS may be flipped during H4, but requires F8 to be completed first. This makes the fallback path impossible in the task runner.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .kiro/specs/phase-8-deployment/tasks.md, line 311:
<comment>H4’s dependency gating contradicts its own execution instructions: it says DNS may be flipped during H4, but requires F8 to be completed first. This makes the fallback path impossible in the task runner.</comment>
<file context>
@@ -0,0 +1,357 @@
+ - Preconditions: F8, H2.
+ - Acceptance criteria: R9.1, R9.2, R9.3, R9.4, R9.5.
+ - Verification: `dig api.stackfast.app +short` matches the Railway edge; `curl -I https://stackfast.app` returns 200; `curl -I http://stackfast.app` returns 301/308 to `https://stackfast.app`.
+ - Dependencies: F8, H2.
+
+- [ ] **H5** Run production smoke and record `/health` evidence `[external]`
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the tasks.md companion to the approved Phase 8 deployment spec (requirements + design merged in PR #6). Breaks the work into 44 dependency-ordered tasks across 9 batches so the
spec-task-executionsub-agent can pick them up one at a time.Batch structure
SENTRY_DSN(no-op when unset)migrate.ts,smoke.ts,rollback.md).env.example+ README production section[docs][external][docs]Total: 44 tasks.
Task format
Each task carries:
requirements.mddesign.md§ 2Ambiguities resolved in this draft
apps/api/src/app.pbt.test.tsfile in C2 rather than alongside the rate-limit PBT.RATE_LIMIT_BACKEND=upstashflip in production is sequenced after the first prod smoke (H5 → H6 → H7) so the cutover has a clean rollback point if the Upstash path misbehaves.CHANGELOG.md.What's next
Once this PR merges, Batch A can start immediately. A1–A6 are all code-only tasks that run in
apps/api/and have no external preconditions.Closes the tasks phase of the Phase 8 deployment spec. Ties back to:
Summary by cubic
Adds
tasks.mdfor Phase 8 deployment, breaking the approved spec into 44 dependency-ordered tasks across 9 batches sospec-task-executioncan run them one by one. Each task includes acceptance criteria, files, verification, and dependencies.RATE_LIMIT_BACKEND=upstashflip after the first smoke for clean rollback.Written for commit aa5baed. Summary will update on new commits.