-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add git-delta diff pager #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @phuongfi91, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
PR Code Suggestions ✨No code suggestions found for the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the git-delta package to the Docker image, which is a useful enhancement for viewing git diffs. However, the implementation is incomplete as it's missing the necessary Git configuration to automatically use delta as the pager. Additionally, a test case should be added to tests/specs.yaml to verify that git-delta is installed correctly by checking its version, which would maintain the test coverage for packages included in the image.
| # Pager for bat | ||
| less \ | ||
| # Pager for git, diff, grep, and blame | ||
| git-delta \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While git-delta is being installed, it's not configured to be used by git automatically. To make this feature useful out-of-the-box, you should configure it as the default pager for git.
You could add this configuration in a subsequent RUN command, for example, by appending it to the command on lines 112-116:
RUN ln -s /usr/bin/eza /usr/local/bin/ls \
&& ln -s /usr/bin/batcat /usr/local/bin/bat \
&& ln -s /usr/bin/fdfind /usr/local/bin/fd \
&& ln -s "$(dirname "$(dirname "$(readlink -f "$(which java)")")")" "${JAVA_HOME}" \
&& git config --global core.pager deltaThis will ensure that users of the image benefit from git-delta without needing manual configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds git-delta as a development tool to the Python base Docker image. Git-delta is a syntax-highlighting pager that enhances git diff output with improved formatting and color schemes.
Key Changes:
- Adds
git-deltapackage installation to the Dockerfile's apt package list
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| bat \ | ||
| # Pager for bat | ||
| less \ | ||
| # Pager for git, diff, grep, and blame |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment describes git-delta as a "Pager for git, diff, grep, and blame", but git-delta is primarily a syntax-highlighting pager for git, not for grep and blame. It's used to enhance git diff, git show, git log, and similar git commands. Consider updating the comment to be more accurate, such as "Syntax-highlighting pager for git diff and log".
| # Pager for git, diff, grep, and blame | |
| # Syntax-highlighting pager for git diff and log |
PR Type
Enhancement
Description
Add
git-deltapackage to Docker imageProvides improved diff paging for git operations
Enhances git, diff, grep, and blame command output
Diagram Walkthrough
File Walkthrough
Dockerfile
Add git-delta package to Docker dependenciesDockerfile
git-deltapackage installation to the apt-get dependencies listlesspager and beforefzffuzzy finderblame operations