Skip to content

feat: Add Pulumi to the tooling #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhassine merged 1 commit into from
Apr 14, 2025
Merged

feat: Add Pulumi to the tooling #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ RUN --mount=type=cache,target=/var/cache/apt \
zsh \
&& pip install --no-cache-dir -U pip setuptools wheel \
&& pip install --no-cache-dir uv \
# Install Pulumi:
&& curl -fsSL https://get.pulumi.com | sh \
Copy link

@gemini-code-assist gemini-code-assist bot Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Installing Pulumi directly from a script can be problematic. It's difficult to ensure reproducibility since you're always getting the latest version. It's also harder to verify the integrity of the installation script. Consider specifying a version or using a package manager if available. This will also help with caching the layer in the Dockerfile.

For example, you could pin a version like this:

curl -fsSL https://get.pulumi.com/ | sh -s -- --version 3.79.0

Alternatively, if Pulumi provides a Debian package, you could install it via apt-get install pulumi after adding the Pulumi package repository.

curl -fsSL https://get.pulumi.com/ | sh -s -- --version <desired_version>

# Install reviewdog:
&& curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh \
| sh -s -- -b /usr/local/bin \
Expand Down