Update HighlightjsIntegration.class.php - #18
Open
D-Groenewegen wants to merge 2 commits into
Open
Conversation
Guard against lang not being set
Owner
|
With the actual code, it seems if the 'lang' variable is not set then PHP will throw a Notice: Undefined variable and the condition will evaluate to false because null is considered falsy. |
Author
|
Hi Nicolas, it will not evaluate to truthy, that's fine, but because the variable is not set, the server logs will be riddled with PHP warnings ( |
Nicolas01
requested changes
Mar 20, 2025
| } | ||
|
|
||
| if ($lang) | ||
| if ( isset( $lang ) && $lang !== '' ) |
Author
There was a problem hiding this comment.
👍 Submitted as suggested. That's better if you need to cater for those cases where $lang may turn out to be false. I removed $lang !== '', which is probably not needed here.
per request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard against 'lang' not being set.