Fix: user balance decimal128 - #867
Merged
Merged
Conversation
|
@Kirtan-pc is attempting to deploy a commit to the Nitya Gosain's projects Team on Vercel. A member of the Team first needs to authorize it. |
Nitya-003
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Overview
This PR fixes the duplicate
balancefield definition inbackend/models/User.jswhere the field was declared twice with conflicting types — first asmongoose.Schema.Types.Decimal128with afromString('100000')default, immediately followed bytype: Numberwithdefault: 100000. Mongoose silently used only the last definition, causing all balance operations to use raw JavaScriptNumberwith floating-point precision instead ofDecimal128, resulting in silent financial rounding errors.🛠️ Type of Change
🔗 Related Issue
Closes #828
🧪 Testing & Verification
npx hardhat testpassed? (Yes/No/NA)User.jsloads without errors and balance usesDecimal128type📸 Screenshots / Demos
N/A
✅ PR Checklist
💬 Additional Notes
The duplicate field was introduced during a previous merge conflict resolution that left both old (
Number) and new (Decimal128) balance definitions in the schema. Removing the duplicateNumberdefinition ensures all balance operations use consistentDecimal128precision for accurate financial calculations across bids, fund transfers, and balance queries.