Handle Darwin-only package updates on Linux workers - #556
Open
TyceHerrman wants to merge 1 commit into
Open
TyceHerrman wants to merge 1 commit into
TyceHerrman wants to merge 1 commit into
Conversation
TyceHerrman
force-pushed
the
fix-darwin-only-update-validation
branch
from
September 29, 2026 22:28
3ceb499 to
d58aae3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #513.
Linux update workers can already update package sources for Darwin-only packages, but validation currently aborts when
nix-buildrejects the package metadata for the Linux host platform. This affects packages such asitsycalandtart.This keeps normal validation strict first. If
nix-buildfails with Nix'snot available on the requested hostPlatformmetadata error, nixpkgs-update retries that build only withallowUnsupportedSystem = true. If the retry succeeds, update processing continues and the generated PR body notes that validation used the unsupported-system fallback. Other build failures still fail normally.Related context
itsycalupdate created because the bot could not complete the Darwin-only package update.Changes
BuildOutcome, unsupported host-platform detection, andbuildForUpdate.buildForUpdatein the update flow.Testing
git diff --check14 examples, 0 failuresnix flake check --all-systemspassed locally from a clean temp copy containing this branch's working-tree changes.nix build .#checks.x86_64-linux.treefmt --no-linkpassed in isolated OrbStack amd64 Debian container.Not completed locally:
cabal test all: blocked in the ad-hoc macOS/mise setup because the doctest subprocess did not inherit the filtered package DB and could not seePolysemy.Plugin.tart/itsycalend-to-end repro: isolated OrbStack amd64 required slow source builds under emulation, so I did not treat it as a useful quick validation path.Formatter note:
nix fmt -- --ciis not supported by this repo's pinned treefmt version.ormolu-0.5.0.1formatter failed with an output reference cycle (bin -> out -> bin), which appears to be old formatter/toolchain cache drift rather than formatting drift in this patch.