Skip to content

Conversation

@SFrijters
Copy link
Member

Eventually this variable should be quoted, but this is backwards compatible for now.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Eventually this variable should be quoted, but this is backwards compatible for now.
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: python Python is a high-level, general-purpose programming language. labels Dec 25, 2025
@SFrijters SFrijters changed the base branch from master to staging December 25, 2025 15:52
@nixpkgs-ci nixpkgs-ci bot closed this Dec 25, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Dec 25, 2025
@SFrijters SFrijters requested a review from uninsane December 30, 2025 21:52
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Dec 30, 2025
@uninsane
Copy link
Contributor

this hook borrows from pkgs/by-name/me/meson/setup-hook.sh; the meson hook itself was made compatible with structuredAttrs here.

i don't know enough about structuredAttrs to say if your approach here is "correct" or not. my intuition would be to track the original meson setup-hook as close as possible though, i.e.

local mesonFlags=()
concatTo flagsArray mesonFlags mesonFlagsArray

tagging @doronbehar for your familiarity in these areas

@uninsane uninsane requested a review from doronbehar December 31, 2025 03:45
@doronbehar
Copy link
Contributor

doronbehar commented Dec 31, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants