Skip to content

ci: don't use the default problems handler in ci - #533355

Closed
jopejoe1 wants to merge 2 commits into
NixOS:masterfrom
jopejoe1:ci-problems
Closed

ci: don't use the default problems handler in ci#533355
jopejoe1 wants to merge 2 commits into
NixOS:masterfrom
jopejoe1:ci-problems

Conversation

@jopejoe1

Copy link
Copy Markdown
Member

This makes it possible to use a custom broken massage or to mark a package as slated for removal without triggering the CI.

closes #523712

Things done

@jopejoe1
jopejoe1 requested a review from infinisil June 19, 2026 17:03
nixpkgs-branch-check[bot]

This comment was marked as outdated.

@nixpkgs-ci
nixpkgs-ci Bot requested a review from a team June 19, 2026 17:08
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions backport release-25.11 backport release-26.05 Backport PR automatically labels Jun 19, 2026
@MattSturgeon

Copy link
Copy Markdown
Contributor
  1. This "adds" 4418 packages that were previously not considered by CI's eval. Presumably due to things like meta.broken?
  2. Addressing this only in Nixpkgs CI may not be enough. IIUC, we also need to update hydra, else meta.problems will be a channel blocker.
  3. How do we decide which "problems" should and shouldn't show up in CI? Currently this assumes no problems should be seen by CI, however it's CI's job to find issues introduced by PRs; e.g. introducing a package that depends on something with "problems" might be something we want CI to detect.

@nixpkgs-branch-check
nixpkgs-branch-check Bot dismissed their stale review June 19, 2026 18:05

Review dismissed automatically

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. labels Jun 19, 2026
This makes it possible to use a custom broken massage or to mark a package as slated for removal without triggering the CI.
@jopejoe1

jopejoe1 commented Jun 19, 2026

Copy link
Copy Markdown
Member Author
  1. This "adds" 4418 packages that were previously not considered by CI's eval. Presumably due to things like meta.broken?

Missed the conditional for when we don't want to include broken packages in ci.

  1. Addressing this only in Nixpkgs CI may not be enough. IIUC, we also need to update hydra, else meta.problems will be a channel blocker.

I don't see how unfree packages and broken packages and others don't block the channel either, so how would this be any diffrent?

  1. How do we decide which "problems" should and shouldn't show up in CI? Currently this assumes no problems should be seen by CI, however it's CI's job to find issues introduced by PRs; e.g. introducing a package that depends on something with "problems" might be something we want CI to detect.

If we want problem to be detected by ci we should add them like i did with broken here but unconditionally.

@infinisil infinisil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until we know what we actually want, let's discuss in #523712

@nixpkgs-ci nixpkgs-ci Bot added the 6.topic: policy discussion Discuss policies to work in and around Nixpkgs label Jun 24, 2026
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 1, 2026
@MattSturgeon

Copy link
Copy Markdown
Contributor

This was superseeded by #533376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. backport release-26.05 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting meta.problems cause eval CI to fail!

4 participants