postgresqlPackages.vectorchord: fix build with rustc 1.96 - #537113
postgresqlPackages.vectorchord: fix build with rustc 1.96#537113CertainLach wants to merge 1 commit into
Conversation
|
Something is wrong here, it still fails to build as a part of nixpkgs |
|
LLVM does some weird things with hardenings used by nixpkgs... |
|
Patch I submitted to VectorChord fixes the individual crate build, but then fat lto during the full extension build breaks it back |
|
Ok, this was hard, but seems like I found the source of the problem :D There is a mismatch in versions of llvm we bundle with rustc in nixpkgs, and upstream rustc (e.g oxalica rust-overlay) expects rustc packaged at staging-next expects llvm to be built with this fix: rust-lang/llvm-project@94e2c19 Simple reproducer I found is: You can build this code on godbolt's rustc 1.96/with oxalica's rust-overlay, but nixpkgs rustc fails to build it with "rustc-LLVM ERROR: Cannot select: intrinsic %llvm.x86.avx512.vpdpbusd.512" error" |
|
@CertainLach Do you have a PR/issue that tracks that problem? I'm interested in knowing if there is still something we need to do on the vectorchord package itself |
Due to a bug in LLVM 21, build fails on x86_64 with: `rustc-LLVM ERROR: Cannot select: intrinsic %llvm.x86.avx512.vpdpbusd.512`. This has been fixed in Rust's build of LLVM and LLVM 22 [1] but this is not reflected in nixpkgs' packaging of rustc. For this reason, we temporarily disable avx512vnni support until this is fixed in nixpkgs. This might cause a performance penalty, but should not affect correctness. See NixOS#537113 (comment) [1]: rust-lang/llvm-project@94e2c19
Due to a bug in LLVM 21, build fails on x86_64 with: `rustc-LLVM ERROR: Cannot select: intrinsic %llvm.x86.avx512.vpdpbusd.512`. This has been fixed in Rust's build of LLVM and LLVM 22 [1] but this is not reflected in nixpkgs' packaging of rustc. For this reason, we temporarily disable avx512vnni support until this is fixed in nixpkgs. This might cause a performance penalty, but should not affect correctness. See NixOS#537113 (comment) [1]: rust-lang/llvm-project@94e2c19
Due to a bug in LLVM 21, build fails on x86_64 with: `rustc-LLVM ERROR: Cannot select: intrinsic %llvm.x86.avx512.vpdpbusd.512`. This has been fixed in Rust's build of LLVM and LLVM 22 [1] but this is not reflected in nixpkgs' packaging of rustc. For this reason, we temporarily disable avx512vnni support until this is fixed in nixpkgs. This might cause a performance penalty, but should not affect correctness. See NixOS#537113 (comment) [1]: rust-lang/llvm-project@94e2c19
Build fails on rustc 1.96, fix submitted upstream: supervc-stack/VectorChord#467
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.