fix: register alien x llm UCEP provider - #10
Open
saurabhhhcodes wants to merge 1 commit into
Open
Conversation
Owner
|
isnt this is a duplicate PR of #8 ? |
Author
|
Hi @Nkovaturient, I've rebased this branch onto the latest main, resolved the merge conflict in index.js, and verified that all syntax checks and Node scripts load cleanly. Ready for review and merge. Thanks! |
Owner
|
@saurabhhhcodes : remove the duplicate PR, and present a snapshot of logs and demo the working as mentioned in the Issue. #1 Demo or Repro (show)Local (expected after fix):
Production:
Current repro: Browser console shows only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LLMServiceand register the realalien-x-llmUCEP provider after the libp2p node startsapp/llm-extension-provider.jsmanifest and command handler forchatandpingwindow.testExtension('alien-x-llm', 'chat', ['ping'])Fixes #1
Root Cause
app/index.jslogged thatalien-x-llmwas registered, but it never calledregisterExtensionfor that provider. The file-transfer path also referencedllmServicewithout creating it, so terminal-side LLM analysis could crash at runtime.Testing
node --check p2p-X/web/app/index.jsnode --check p2p-X/web/app/llm-extension-provider.jsgit diff --checknpm ciinp2p-X/web/appINTERACTIVE=false TIMEOUT_DURATION=5s npm startinp2p-X/web/appRegistering extension: alien-x-llm v1.0.0 at /uc/extension/alien-x-llm/1.0.0Extension alien-x-llm registered and will be advertised via IdentifyNotes
npm cireports existing dependency audit findings (3 moderate, 4 high). This PR does not change dependencies.