[mlir] Replace int64_t sentinel for dynamic Sol_ArrayType size with std::optional<APInt>#142
Open
PavelKopyl wants to merge 1 commit into
Open
[mlir] Replace int64_t sentinel for dynamic Sol_ArrayType size with std::optional<APInt>#142PavelKopyl wants to merge 1 commit into
PavelKopyl wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Solidity-to-MLIR lowering to align with the Sol MLIR dialect’s new representation for array sizes (replacing an int64_t dynamic-size sentinel with std::optional<llvm::APInt>), and adds regression coverage for extremely large static array sizes (up to 2**256 - 1).
Changes:
- Switch MLIR array type construction to use
std::optional<llvm::APInt>(withstd::nulloptfor dynamic arrays) and preserve size viagetSizeOpt(). - Add
litcodegen tests that exerciseuint[(2**256)-1]static arrays in both init-MLIR and EVM-MLIR output. - Remove two entries from the MLIR semantic test known-failures list (indicating they are expected to pass now).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/mlirSemtestFailures.txt |
Removes two tests from the known-failures list. |
test/lit/mlirCodegen/EVM/array-huge-static.sol |
Adds EVM MLIR codegen regression test for max-sized static array type. |
test/lit/mlirCodegen/array-huge-static.sol |
Adds init MLIR regression test asserting correct printing of max-sized static array type. |
libsolidity/codegen/mlir/SolidityToMLIR.cpp |
Adapts array type lowering to use std::optional<APInt> size and getSizeOpt(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…td::optional<APInt>
b628ecb to
bff755b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matter-labs/solx-llvm#85