refactor: eliminate all unwrap() calls from Rust codebase #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace all unwrap() calls with proper error handling: - Use expect() with descriptive messages for programmer errors - Use unwrap_or_else() for graceful fallbacks - Proper error handling in metrics encoder Changes: - Prometheus metrics: unwrap() → expect() (6 instances) - Health serialization: unwrap() → unwrap_or_else() with JSON fallback (36 instances) - Metrics encoder: unwrap() → match with HTTP 500 error response (1 instance) - MongoDB field access: improved default values (8 instances) - Test assertions: unwrap() → expect() with descriptive messages (4 instances) All 44 tests pass successfully. Total unwrap() calls eliminated: 55 (51 from main.rs, 4 from tests.rs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates all
unwrap()calls from the Rust reference API codebase to prevent potential panics in production.Changes
unwrap()→expect()with descriptive error messages (6 instances)unwrap()→unwrap_or_else()with JSON fallback (36 instances)unwrap()→expect()with descriptive messages (4 instances)Testing
unwrap()calls remain with grep searchTotal Impact
55 unwrap() calls eliminated: 51 from
main.rs, 4 fromtests.rsThe codebase now handles all potential errors gracefully without risk of unexpected panics.