Conversation
dpslwk
left a comment
There was a problem hiding this comment.
HMS code base uses single quoted strings with concatenation . not interpolation
Audit runs weekdays only not daily.
The message is form the "Hackspace Management System" bot not sure it needs to be pointed out in every message.
I don't like the mixing of the count in to sentences as it makes scanning the notification for just the numbers hard, word prefer them to be on separate lines,
there is also existing wording in the email version in auditResults.blade.php
bare in mind that the public discord membership channel is fairly quite and so there will be weeks when all the channel sees is the same thing posted over and over
|
HMS code base uses single quoted strings with concatenation . not interpolation - amended, my bad, in my day job interpolation is seen as clearer. Audit runs weekdays only not daily - amended to reflect that. The message is form the "Hackspace Management System" bot not sure it needs to be pointed out in every message - message text adjusted to remove the duplicate mention of HMS. I don't like the mixing of the count in to sentences as it makes scanning the notification for just the numbers hard, word prefer them to be on separate lines - The intended audience isn't "us", it is all of the membership. In my view English sentences are better for that. there is also existing wording in the email version in auditResults.blade.php - yes, I see that email every weekday. I have reused that wording, tweaked slightly for the intended audience. bare in mind that the public discord membership channel is fairly quite and so there will be weeks when all the channel sees is the same thing posted over and over - true, but not sure that is an issue? |
No description provided.