[feat][train] Enable new inference codepath by default#1480
Draft
SumanthRH wants to merge 3 commits intogpu-ci-migrationfrom
Draft
[feat][train] Enable new inference codepath by default#1480SumanthRH wants to merge 3 commits intogpu-ci-migrationfrom
SumanthRH wants to merge 3 commits intogpu-ci-migrationfrom
Conversation
Flip _SKYRL_USE_NEW_INFERENCE default from "0" to "1" so the new RemoteInferenceClient HTTP-based inference layer is active unless explicitly opted out. Update conftest.py to import the flag from skyrl.env_vars instead of re-reading os.environ with a stale default, and update the docstring to reflect the new default. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…erence default Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
_SKYRL_USE_NEW_INFERENCEdefault from "0" to "1" so the newRemoteInferenceClientHTTP-based inference layer is active unless explicitly opted out.conftest.pyto import the flag fromskyrl.env_varsinstead of re-readingos.environwith a stale default, and update the docstring to reflect the new default.