Add ppo as alias for dual_clip policy loss type#1481
Draft
j316chuck wants to merge 3 commits intoNovaSky-AI:mainfrom
Draft
Add ppo as alias for dual_clip policy loss type#1481j316chuck wants to merge 3 commits intoNovaSky-AI:mainfrom
j316chuck wants to merge 3 commits intoNovaSky-AI:mainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add ppo as alias for dual_clip policy loss type
Changed the ppo_policy_loss function to treat "ppo" the same as "regular" rather than grouping it with "dual_clip". This means "ppo" will now use standard PPO clipping without the additional dual-clip logic for negative advantages. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Tested on 1x8xH100, dual_clip and ppo produce the same loss curves