[19.0] [MIG] document_knowledge: Migration to 19.0#569
[19.0] [MIG] document_knowledge: Migration to 19.0#569BhaveshHeliconia wants to merge 55 commits intoOCA:19.0from
Conversation
|
Hi, I reviewed the module on 19.0 and all checks are green. Could you please confirm if this PR is ready to be merged, or if any additional changes are required? Thanks! |
|
@stferraro Thanks for reviewing the PR and leaving comments. However, comments alone don’t mark the PR as approved. To approve it, please go to the Files changed tab, click the green Review changes button, select Approve if everything looks fine, and then submit. That’s the process to approve a PR.
|
|
This PR has the |
farhatzafar
left a comment
There was a problem hiding this comment.
In document_knowledge/demo/document_knowledge.xml: groups_id should be changed to group_ids. Other than this, I have tested it on Odoo 19 and the migration looks complete.
* Copyright and various stuff * Contributors * External ID not found in the system: base.group_document_user
Currently translated at 93.9% (31 of 33 strings) Translation: knowledge-11.0/knowledge-11.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-11-0/knowledge-11-0-knowledge/pt_BR/
It solves this: OCA#179
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Otherwise the module grants too wide permissions for all users.
Currently translated at 88.4% (23 of 26 strings) Translation: knowledge-15.0/knowledge-15.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-knowledge/tr/
Currently translated at 100.0% (26 of 26 strings) Translation: knowledge-15.0/knowledge-15.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-knowledge/fr/
In v16 Odoo has its own knowledge module
Currently translated at 100.0% (21 of 21 strings) Translation: knowledge-17.0/knowledge-17.0-document_knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-17-0/knowledge-17-0-document_knowledge/sv/
Currently translated at 100.0% (21 of 21 strings) Translation: knowledge-17.0/knowledge-17.0-document_knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-17-0/knowledge-17-0-document_knowledge/ca/
[IMP] document_knowledge: pre-commit execution
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-18.0/knowledge-18.0-document_knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-18-0/knowledge-18-0-document_knowledge/
Currently translated at 100.0% (15 of 15 strings) Translation: knowledge-18.0/knowledge-18.0-document_knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-18-0/knowledge-18-0-document_knowledge/it/
Currently translated at 100.0% (15 of 15 strings) Translation: knowledge-18.0/knowledge-18.0-document_knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-18-0/knowledge-18-0-document_knowledge/sv/
666a01d to
3457a90
Compare
3457a90 to
14e16ed
Compare
|
@farhatzafar Fixed groups_id → group_ids |
|
This PR has the |
No description provided.