[MIG] base_group_backend: Migration to 18.0 by FranzPoize · Pull Request #373 · OCA/server-backend

FranzPoize · 2025-08-05T16:30:20Z

Migration to 18.0:

has_groups now inherits from _has_groups (because has_groups has changed see [IMP] core: remove user_has_groups() odoo/odoo#151597)
changed groups in ir.rule to reflect change from mail to discuss
adds reads permission to res.users it is now needed to login

bealdav

LGTM, thanks

OCA-git-bot · 2025-11-07T09:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

bguillot · 2026-01-20T13:19:37Z

/ocabot merge nobump

OCA-git-bot · 2026-01-20T13:19:45Z

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-373-by-bguillot-bump-nobump, awaiting test results.

Signed-off-by bguillot

bguillot · 2026-01-20T13:22:29Z

Thanks

OCA-git-bot · 2026-01-20T13:24:14Z

@bguillot The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name server-backend --branch 18.0 --addons-dir /tmp/tmpafhfroy4 --commit failed with output:

/tmp/tmpafhfroy4/base_group_backend/README.rst:130: (ERROR/3) Duplicate substitution definition name: "image1".
Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 7, in <module>
    sys.exit(gen_addon_readme())
             ^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1462, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1383, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1246, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 814, in invoke
    return callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 575, in gen_addon_readme
    check_rst(readme_filename)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 398, in check_rst
    publish_file(
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 465, in publish_file
    output, _publisher = publish_programmatically(
                         ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 794, in publish_programmatically
    output = publisher.publish(enable_exit_status=enable_exit_status)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 269, in publish
    self.document = self.reader.read(self.source, self.parser,
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 95, in read
    self.parse()
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 101, in parse
    self.parser.parse(self.input, document)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/__init__.py", line 185, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 182, in run
    results = StateMachineWS.run(self, input_lines, input_offset,
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 234, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 446, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2487, in explicit_markup
    nodelist, blank_finish = self.explicit_construct(match)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2499, in explicit_construct
    return method(self, expmatch)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2215, in substitution_def
    self.document.note_substitution_def(
  File "/ocamt/lib/python3.12/site-packages/docutils/nodes.py", line 2063, in note_substitution_def
    msg = self.reporter.error(
          ^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 256, in error
    return self.system_message(self.ERROR_LEVEL, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 217, in system_message
    raise SystemMessage(msg, level)
docutils.utils.SystemMessage: /tmp/tmpafhfroy4/base_group_backend/README.rst:130: (ERROR/3) Duplicate substitution definition name: "image1".

FranzPoize · 2026-01-20T13:59:07Z

I'll look into it

…up_backend As a developer we have to keep in mind using this module and grant a user with 's group is equivalent to grant 's group everywhere has been used. Co-authored-by: Jean-Charles Drubay <jcdrubay@users.noreply.github.com>

FIX applies pre-commit IMPL adds test for share of backend user FIX pre-commit pass IMPL removes mail.activity.mixin from dummy model because it is not needed for the test IMPL renames and divide the base_group_backend into 2 groups one that provide the basic rights and another that allow login in the app IMPL changes backend ui users to a user type FIX pre-commit pass FIX removes useless imports FIX adds share to group_backend_ui_users IMPL adds mail_channel to access rights FIX tests now working FIX pre-commit pass

for Backend UI Users

Currently translated at 100.0% (23 of 23 strings) Translation: server-backend-16.0/server-backend-16.0-base_group_backend Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_group_backend/it/

florian-dacosta · 2026-03-04T16:48:18Z

I did rebase, can you try again to merge @bguillot

bguillot · 2026-03-04T20:44:34Z

/ocabot merge nobump

OCA-git-bot · 2026-03-04T20:44:42Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-373-by-bguillot-bump-nobump, awaiting test results.

Signed-off-by bguillot

OCA-git-bot · 2026-03-04T20:49:15Z

@bguillot The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name server-backend --branch 18.0 --addons-dir /tmp/tmp22e0gypn --commit failed with output:

/tmp/tmp22e0gypn/base_group_backend/README.rst:130: (ERROR/3) Duplicate substitution definition name: "image1".
Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 6, in <module>
    sys.exit(gen_addon_readme())
             ^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1485, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1406, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1269, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 824, in invoke
    return callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 575, in gen_addon_readme
    check_rst(readme_filename)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 398, in check_rst
    publish_file(
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 465, in publish_file
    output, _publisher = publish_programmatically(
                         ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 794, in publish_programmatically
    output = publisher.publish(enable_exit_status=enable_exit_status)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 269, in publish
    self.document = self.reader.read(self.source, self.parser,
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 95, in read
    self.parse()
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 101, in parse
    self.parser.parse(self.input, document)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/__init__.py", line 185, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 182, in run
    results = StateMachineWS.run(self, input_lines, input_offset,
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 234, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 446, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2487, in explicit_markup
    nodelist, blank_finish = self.explicit_construct(match)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2499, in explicit_construct
    return method(self, expmatch)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2215, in substitution_def
    self.document.note_substitution_def(
  File "/ocamt/lib/python3.12/site-packages/docutils/nodes.py", line 2063, in note_substitution_def
    msg = self.reporter.error(
          ^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 256, in error
    return self.system_message(self.ERROR_LEVEL, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 217, in system_message
    raise SystemMessage(msg, level)
docutils.utils.SystemMessage: /tmp/tmp22e0gypn/base_group_backend/README.rst:130: (ERROR/3) Duplicate substitution definition name: "image1".

… file

florian-dacosta · 2026-03-04T22:08:29Z

I think I fixed the conflict name in images, can you try once more @bguillot

bguillot · 2026-03-05T08:47:39Z

/ocabot merge nobump

OCA-git-bot · 2026-03-05T08:47:46Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-373-by-bguillot-bump-nobump, awaiting test results.

OCA-git-bot · 2026-03-05T08:53:01Z

Congratulations, your PR was merged at 91592c9. Thanks a lot for contributing to OCA. ❤️

bealdav approved these changes Nov 6, 2025

View reviewed changes

FranzPoize force-pushed the 18.0-mig-base_group_backend branch from 07eacca to 9de4448 Compare November 6, 2025 09:11

hparfr approved these changes Nov 7, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Nov 7, 2025

OCA-git-bot added a commit that referenced this pull request Jan 20, 2026

Merge PR #373 into 18.0

a6bec93

Signed-off-by bguillot

OCA-git-bot added the bot is merging ⏳ label Jan 20, 2026

florian-dacosta approved these changes Jan 20, 2026

View reviewed changes

OCA-git-bot removed the bot is merging ⏳ label Jan 20, 2026

petrus-v and others added 13 commits March 4, 2026 17:47

FIX base_grp_backend: precommit and better names in ir.model.access

e243f9f

IMP base_grp_backend: set doc picture

3a46d2e

[UPD] Update base_group_backend.pot

29834b8

[BOT] post-merge updates

893b032

Added translation using Weblate (Italian)

2c7a277

[IMP] base_group_backend: allow read on calendar.event

7aaf42a

[FIX] avoid display root menus with no defined security groups

5dab0ec

for Backend UI Users

[IMP] Re-write README

68ac383

Translated using Weblate (Italian)

ec51d8c

Currently translated at 100.0% (23 of 23 strings) Translation: server-backend-16.0/server-backend-16.0-base_group_backend Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_group_backend/it/

[IMP] base_group_backend: pre-commit auto fixes

290d10a

[MIG] base_group_backend: Migration to 18.0

0e84134

florian-dacosta force-pushed the 18.0-mig-base_group_backend branch from 9de4448 to 0e84134 Compare March 4, 2026 16:47

OCA-git-bot added a commit that referenced this pull request Mar 4, 2026

Merge PR #373 into 18.0

4fd9e0a

Signed-off-by bguillot

OCA-git-bot added the bot is merging ⏳ label Mar 4, 2026

OCA-git-bot removed the bot is merging ⏳ label Mar 4, 2026

[FIX] name images in README to avoid conflict when generating the rst…

7ed809c

… file

OCA-git-bot added the bot is merging ⏳ label Mar 5, 2026

OCA-git-bot merged commit 7650a5c into OCA:18.0 Mar 5, 2026
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 5, 2026

Uh oh!

Conversation

FranzPoize commented Aug 5, 2025

Uh oh!

bealdav left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Nov 7, 2025

Uh oh!

bguillot commented Jan 20, 2026

Uh oh!

OCA-git-bot commented Jan 20, 2026

Uh oh!

bguillot commented Jan 20, 2026

Uh oh!

OCA-git-bot commented Jan 20, 2026

Uh oh!

FranzPoize commented Jan 20, 2026

Uh oh!

florian-dacosta commented Mar 4, 2026

Uh oh!

bguillot commented Mar 4, 2026

Uh oh!

OCA-git-bot commented Mar 4, 2026

Uh oh!

OCA-git-bot commented Mar 4, 2026

Uh oh!

florian-dacosta commented Mar 4, 2026

Uh oh!

bguillot commented Mar 5, 2026

Uh oh!

OCA-git-bot commented Mar 5, 2026

Uh oh!

Uh oh!

OCA-git-bot commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants