Skip to content

add action: uses table_concept_id if available#71

Open
ginberg wants to merge 2 commits into
developfrom
issue50
Open

add action: uses table_concept_id if available#71
ginberg wants to merge 2 commits into
developfrom
issue50

Conversation

@ginberg

@ginberg ginberg commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

see #50
add operation:

  • use given concept_id if available
  • extend current check for empty values
  • add test

@ginberg

ginberg commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

could you try if this PR fixes #50 @laacri?

@laacri laacri left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works code-wise and the tests pass.

I replicated the gui scenario from issue #50 starting with a default observation period:

Screenshot 2026-06-26 171511

Then I assigned a condition occurrence by searching its concept, and it is added correctly with its id:

Screenshot 2026-06-26 171553

@laacri

laacri commented Jun 26, 2026

Copy link
Copy Markdown

However, I noticed that if I try adding a second condition occurrence after that, the concept id of the new condition is assigned to the first one too:

image

If I try adding another one, the first one retains the id of the second which was assigned in the previous step, while the second one takes the id of the newly added one:

image

And so on if I keep adding condition occurrences. As for the dates, I just left the default ones for all of them. So the original problem with default ids is resolved, but there seems to be still something weird in the way the ids are updated when a new condition occurrence is added. I'm not sure if we want to address this in a new issue/branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants