Detect list rule proto 635 v1 #14380
Open
+106
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catenacyber
requested review from
jasonish,
jufajardini and
victorjulien
as code owners
catenacyber
force-pushed
the
detect-list-rule-proto-635-v1
branch
from
9551c67 to
617d5d7
Compare
Contributor
Author
|
Force-pushed rust bindings update |
To use an array, instead of hard-coded values. Opens the path to list the rule protocols Ticket: 635
To list the protocols we can use a in a rule header Ticket: 635
catenacyber
force-pushed
the
detect-list-rule-proto-635-v1
branch
from
617d5d7 to
b479345
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14380 +/- ##
==========================================
- Coverage 84.19% 84.18% -0.02%
==========================================
Files 1012 1012
Lines 261796 261793 -3
==========================================
- Hits 220414 220380 -34
- Misses 41382 41413 +31
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 28552 |
|
|
||
| struct { | ||
| const char *name; | ||
| uint8_t proto; |
Member
There was a problem hiding this comment.
should we make this an int and use -1 as not set? Technically 0 is a valid ip protocol number https://www.iana.org/assignments/protocol-numbers/protocol-numbers.xhtml
Contributor
Author
There was a problem hiding this comment.
Ok as long as one of the rule-proto keywords does not set it ;-)
victorjulien
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/635
Describe changes:
--list-rule-protosto show tcp-pkt and other