Skip to content

Add CO2SOL and H2SOL for regression#6952

Merged
totto82 merged 1 commit intoOPM:masterfrom
totto82:test_co2h2sol
Apr 16, 2026
Merged

Add CO2SOL and H2SOL for regression#6952
totto82 merged 1 commit intoOPM:masterfrom
totto82:test_co2h2sol

Conversation

@totto82
Copy link
Copy Markdown
Member

@totto82 totto82 commented Mar 19, 2026

No description provided.

@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Mar 19, 2026

jenkins build this update_data please

@totto82 totto82 added the manual:irrelevant This PR is a minor fix and should not appear in the manual label Mar 19, 2026
jenkins4opm pushed a commit to jenkins4opm/opm-tests that referenced this pull request Mar 19, 2026
Reason: PR OPM/opm-simulators#6952

opm-common     = 3e248268e90ef38c752b1f41a0c92a8b86b9c9ac
opm-grid       = 21f4c65c17f32602dd78f18eb08e093bd0a0994c
opm-simulators = 8f0762e3b9c12a1b0b3e0ad9153cd2bafc283d49

### Changed Tests ###

  * spe1_co2sol
  * spe1_h2sol
@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Mar 19, 2026

jenkins build this opm-tests=1511 please

3 similar comments
@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Mar 19, 2026

jenkins build this opm-tests=1511 please

@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Mar 23, 2026

jenkins build this opm-tests=1511 please

@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Apr 15, 2026

jenkins build this opm-tests=1511 please

@totto82 totto82 requested a review from svenn-t April 15, 2026 09:15
Copy link
Copy Markdown
Contributor

@svenn-t svenn-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding CO2SOL/H2SOL tests. This can be merged.

Food for thought: should we add enable-opm-rst-file=true arguments to these and other tests like CO2STORE and H2STORE? Otherwise, outputs like RSW, RVW, etc. will not be compared, as I understand it.

@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Apr 15, 2026

Yes we should. I will update accordingly and merge afterward.

@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Apr 16, 2026

jenkins build this update_data please

jenkins4opm pushed a commit to jenkins4opm/opm-tests that referenced this pull request Apr 16, 2026
Reason: PR OPM/opm-simulators#6952

opm-common     = 65e3d1a5f20bf13425299d4e02ae278d93a714e9
opm-grid       = 25b665010d3bb788c313d440ff2eee993b00535a
opm-simulators = 80224806d7481fe7d8950eb60a506bf5249c7eae

### Changed Tests ###

  * spe1_co2sol
  * spe1_h2sol
  * spe1_gaswater_solvent
@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Apr 16, 2026

jenkins build this update_data please

jenkins4opm pushed a commit to jenkins4opm/opm-tests that referenced this pull request Apr 16, 2026
Reason: PR OPM/opm-simulators#6952

opm-common     = 6a8e8368c5f63be9ac18b39232d7aebcfb7db8a4
opm-grid       = 25b665010d3bb788c313d440ff2eee993b00535a
opm-simulators = 73d3d00090ba78eaad6245f36ad2059140ea5787

### Changed Tests ###

  * spe1_h2sol
  * spe1_co2sol
@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Apr 16, 2026

jenkins build this opm-tests=1511 please

@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Apr 16, 2026

jenkins build this opm-tests=1518 please

totto82 added a commit to OPM/opm-tests that referenced this pull request Apr 16, 2026
@totto82 totto82 merged commit 8509d5f into OPM:master Apr 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants