fix: use keyword bvecs= in gradient_table() calls to suppress dipy deprecation warning - #157
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a dipy deprecation warning in all 6 IAR_LU_ algorithms by converting bvec from a positional argument to the keyword form bvecs=bvec when calling gradient_table().
dipy 1.11.0 emits the following deprecation warning when
bvecis passed positionally:This will become a hard error in dipy 2.0.0, breaking all 6 IAR_LU algorithms.
Changed 11 call sites across 6 files from:
to:
Files Changed
IAR_LU_biexp.py__init__(2 other sites were already fixed)IAR_LU_modified_mix.py__init__andivim_fitIAR_LU_modified_topopro.py__init__andivim_fitIAR_LU_segmented_2step.py__init__andivim_fitIAR_LU_segmented_3step.py__init__andivim_fitIAR_LU_subtracted.py__init__andivim_fitTesting
test_ivim_fit_savedtests pass (89 skipped, 11 xfailed, 4 xpassed).bug_2/reproduce_dipy_warning.py) that the warning is no longer emitted after the fix.Fixes #156