removed assertions

[anirudhprmar]

Proposed change

Resolves #3032

removed the use of assertions

Checklist

• Required: I read and followed the contributing guidelines
• Required: I ran make check-test locally and all tests passed
• I used AI for code, documentation, or tests in this PR

[coderabbitai]

Summary by CodeRabbit

• Tests
  • Enhanced test validation with explicit null checks to improve test reliability and prevent potential runtime errors during component testing.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Walkthrough

This PR removes unnecessary non-null assertions (!) from the UserMenu test file by replacing direct DOM queries with explicit null guards. The dropdownId variable is now validated before accessing document.getElementById(), improving type safety and addressing a SonarCloud linting rule.

Changes

Cohort / File(s)	Summary
Test null-safety improvements frontend/__tests__/unit/components/UserMenu.test.tsx	Two test blocks updated to guard against null dropdownId before DOM lookups; replaced document.getElementById(dropdownId!) with conditional checks followed by document.getElementById(dropdownId)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• test: add unit tests for UserMenu component (#1918) #1948: Directly related as it added the original test code to UserMenu.test.tsx that this PR now refactors with null-safety improvements.

Suggested labels

frontend, frontend-tests

Suggested reviewers

• arkid15r
• kasya

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is overly vague and generic, using only 'removed assertions' without specifying which file or component is affected, making it difficult to understand the specific change from PR history.	Provide a more specific title such as 'Remove unnecessary non-null assertion in UserMenu test' to clearly convey the main change and affected component.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description clearly references issue #3032 and explains the removal of TypeScript assertions, directly relating to the changeset in UserMenu.test.tsx.
Linked Issues check	✅ Passed	The PR changes fully satisfy issue #3032 by removing unnecessary non-null assertions in UserMenu.test.tsx, replacing direct use of dropdownId! with a guarded approach as required.
Out of Scope Changes check	✅ Passed	All changes are scoped to UserMenu.test.tsx and directly address the removal of redundant non-null assertions specified in issue #3032, with no unrelated modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7e38d6a and 34df37a.

📒 Files selected for processing (1)

• frontend/__tests__/unit/components/UserMenu.test.tsx

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: rudransh-shrivastava
Repo: OWASP/Nest PR: 2178
File: frontend/src/app/snapshots/[id]/page.tsx:0-0
Timestamp: 2025-09-21T17:04:48.154Z
Learning: User rudransh-shrivastava confirmed that suggested type safety improvements during Apollo Client migration were no longer relevant, reinforcing their preference to keep migration PRs focused on core migration changes rather than additional improvements.

Learnt from: anurag2787
Repo: OWASP/Nest PR: 2671
File: frontend/__tests__/unit/components/MultiSearch.test.tsx:427-427
Timestamp: 2025-11-17T16:47:05.578Z
Learning: In the frontend test files for the OWASP/Nest repository, `expect(true).toBe(true)` no-op assertions may be intentionally added as workarounds when ESLint rule jest/expect-expect doesn't detect expectations inside helper functions or waitFor callbacks. These can be resolved by configuring the ESLint rule's assertFunctionNames option to recognize custom assertion helpers instead of flagging them as redundant.

🔇 Additional comments (1)

frontend/__tests__/unit/components/UserMenu.test.tsx (1)

623-627: No changes needed—code compiles without errors.

The explicit null check with expect(dropdownId).not.toBeNull() is appropriate. TypeScript strict mode is disabled in this project ("strict": false in tsconfig.json), so the type narrowing behavior you mentioned is not a concern here. The code compiles successfully without requiring type guards or assertions.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud