Oasislmf ci testing#28
Conversation
|
PiWindComplex model ~ Claude Changes and rationale: 1. 2. 3. 4. 5. 6. 7. |
1. Bug: events_pd.size returns rows × cols, not rows — events are silently miscounted 2. eval called twice per row in model_data parsing (once per field) 3. Row-by-row apply(lambda) for bin_height — vectorizable in one line 4. iterrows() loop with boolean masking for random numbers — O(n) full-DataFrame scan per item 5. apply(calculate_guls, axis=1) — row-by-row Python apply, should be np.where 6. O(n²) write_loss_stream — inner boolean filter re-scans the entire DataFrame per (event_id, item_id) pair 7. struct.pack one field at a time — many small writes; batch them with numpy structured arrays
No description provided.