Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/accounts/account_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ func Update(client newclient.Client, account IAccount) (IAccount, error) {
return ToAccount(res)
}

// DeleteByID will delete a account with the provided id.
// DeleteByID will delete an account with the provided id.
func DeleteByID(client newclient.Client, spaceID string, id string) error {
return newclient.DeleteByID(client, template, spaceID, id)
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/certificates/certificate_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type CertificateService struct {
services.CanDeleteService
}

// NewCertificateService returns an certificateService with a preconfigured client.
// NewCertificateService returns a certificateService with a preconfigured client.
func NewCertificateService(sling *sling.Sling, uriTemplate string) *CertificateService {
return &CertificateService{
CanDeleteService: services.CanDeleteService{
Expand Down
2 changes: 1 addition & 1 deletion pkg/channels/channel_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func (s *ChannelService) Get(channelsQuery Query) (*resources.Resources[*Channel
// GetAll returns all channels. If none can be found or an error occurs, it
// returns an empty collection.
//
// Depreacted: use channels.GetAll
// Deprecated: use channels.GetAll
func (s *ChannelService) GetAll() ([]*Channel, error) {
items := []*Channel{}
path, err := services.GetAllPath(s)
Expand Down
4 changes: 2 additions & 2 deletions pkg/feeds/feed_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ type FeedService struct {
services.CanDeleteService
}

// NewFeedService returns an feed service with a preconfigured client.
// NewFeedService returns a feed service with a preconfigured client.
func NewFeedService(sling *sling.Sling, uriTemplate string, builtInFeedStats string) *FeedService {
return &FeedService{
builtInFeedStats: builtInFeedStats,
Expand Down Expand Up @@ -286,7 +286,7 @@ func Update(client newclient.Client, feed IFeed) (IFeed, error) {
return ToFeed(res)
}

// DeleteByID will delete a account with the provided id.
// DeleteByID will delete an account with the provided id.
func DeleteByID(client newclient.Client, spaceID string, id string) error {
return newclient.DeleteByID(client, template, spaceID, id)
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/observability/resource_manifest_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (

func TestGetResourceManifestRequest_IsTenanted(t *testing.T) {
// Test untenanted request
untenanteRequest := &GetResourceManifestRequest{
untenantedRequest := &GetResourceManifestRequest{
SpaceID: "Spaces-1",
ProjectID: "Projects-1",
EnvironmentID: "Environments-1",
Expand All @@ -17,7 +17,7 @@ func TestGetResourceManifestRequest_IsTenanted(t *testing.T) {
DesiredOrKubernetesMonitoredResourceID: "Resources-1",
}

assert.False(t, untenanteRequest.IsTenanted())
assert.False(t, untenantedRequest.IsTenanted())

// Test tenanted request
tenantedRequest := &GetResourceManifestRequest{
Expand Down
4 changes: 2 additions & 2 deletions pkg/observability/resource_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
func TestGetResourceRequest_IsTenanted(t *testing.T) {
t.Run("should return untenanted resource", func(t *testing.T) {
// Test untenanted request
untenanteRequest := &GetResourceRequest{
untenantedRequest := &GetResourceRequest{
SpaceID: "Spaces-1",
ProjectID: "Projects-1",
EnvironmentID: "Environments-1",
Expand All @@ -20,7 +20,7 @@ func TestGetResourceRequest_IsTenanted(t *testing.T) {
DesiredOrKubernetesMonitoredResourceID: "Resources-1",
}

assert.False(t, untenanteRequest.IsTenanted())
assert.False(t, untenantedRequest.IsTenanted())
})

t.Run("should return tenanted resource", func(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/packages/package_delta_upload.go
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ func deltaFallbackUploadFullFile(

// requestDeltaSignature asks the server for a signature for a package (packageId and version in the params map).
// If the server returns 404 (not found) this indicates there's no existing package to delta off, in which case
// requestDeltaSignature will return (nil, nil) indiciating no signature but also no error.
// requestDeltaSignature will return (nil, nil) indicating no signature but also no error.
func requestDeltaSignature(client newclient.Client, params map[string]any) (*PackageSignatureResponse, error) {
signatureUri, err := client.URITemplateCache().Expand(uritemplates.PackageDeltaSignature, params)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion pkg/spaces/space_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ func Update(client newclient.Client, space *Space) (*Space, error) {
return res, nil
}

// GetDefaultSpace tries to find default space. Returns nil if a default space can not be found.
// GetDefaultSpace tries to find default space. Returns nil if a default space cannot be found.
func GetDefaultSpace(client newclient.Client) (*Space, error) {
// TODO: this should change to return a custom error (can't find default space)
spaces, err := GetAll(client)
Expand Down
2 changes: 1 addition & 1 deletion pkg/triggers/project_trigger_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func TestTriggerJsonSerialization(t *testing.T) {
})

t.Run("deserialize OnceDailySchedule filter from a 2022.3 server", func(t *testing.T) {
// Note the Startime with 3 decimal places of milliseconds, with no timezone info, which Go doesn't normally deal with
// Note the StartTime with 3 decimal places of milliseconds, with no timezone info, which Go doesn't normally deal with
// captured verbatim from real server
data := []byte(heredoc.Doc(`
{
Expand Down
6 changes: 3 additions & 3 deletions pkg/variables/variable_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func (s *VariableService) GetByName(ownerID string, name string, scope *Variable
return matchedVariables, nil
}

// AddSingle adds a single variable to a owner ID. This automates the act of fetching
// AddSingle adds a single variable to an owner ID. This automates the act of fetching
// the variable set, adding a new item to it, and posting back to Octopus
//
// Deprecated: Use variables.AddSingle
Expand All @@ -153,7 +153,7 @@ func (s *VariableService) AddSingle(ownerID string, variable *Variable) (Variabl
return s.Update(ownerID, variables)
}

// UpdateSingle adds a single variable to a owner ID. This automates the act of fetching
// UpdateSingle adds a single variable to an owner ID. This automates the act of fetching
// the variable set, updating the existing item, and posting back to Octopus
//
// Deprecated: Use variables.UpdateSingle
Expand Down Expand Up @@ -181,7 +181,7 @@ func (s *VariableService) UpdateSingle(ownerID string, variable *Variable) (Vari
return VariableSet{}, services.ErrItemNotFound
}

// DeleteSingle removes a single variable from a owner ID. This automates the act of fetching
// DeleteSingle removes a single variable from an owner ID. This automates the act of fetching
// the variable set, removing the existing item, and posting back to Octopus
//
// Deprecated: Use variables.DeleteSingle
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/feed_service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ func TestFeedServiceSearchPackages(t *testing.T) {
defer DeleteTestFeed(t, client, feed)

searchPackagesQuery := feeds.SearchPackagesQuery{
Term: "ngnix",
Term: "nginx",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really not at all sure what this is trying to achieve. It's really strange. I spent a bit of time trying to figure it out and gave up.

Take: 10,
}

Expand Down