perf: lazily serialize peer to avoid hot-path allocations #16028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Does not build though. beacon-chain/p2p/fork.go:55:16: peer.String undefined (type *enr.Record has no field or method String) |
Contributor
Author
corrected, must be ok i think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the unconditional ENR serialization in compareForkENR and makes it lazy-only for logging/error paths with a safe fallback to peer.String(). The function is invoked in the discovery hot path via filterPeer, so doing a base64+RLP encode for every candidate—even for the common match case—wastes CPU and allocations. Other call sites serialize ENR strings only when needed (e.g., RPC responses), so this aligns with established patterns. The core compatibility checks remain unchanged; we simply avoid failing the function due to an auxiliary logging serialization failure.