Skip to content

Fix Windows git untracked status for canonicalized paths#161

Merged
OlaProeis merged 1 commit into
OlaProeis:0.3.1-experimentalfrom
starSumi:fix/windows-git-untracked-test-ci-followup
Jun 19, 2026
Merged

Fix Windows git untracked status for canonicalized paths#161
OlaProeis merged 1 commit into
OlaProeis:0.3.1-experimentalfrom
starSumi:fix/windows-git-untracked-test-ci-followup

Conversation

@starSumi

Copy link
Copy Markdown
Contributor

Summary

  • follow up the lingering Windows CI failure in vcs::git::tests::test_git_service_untracked_file that still reproduced on GitHub Actions after fix: handle Windows verbatim git paths #160
  • canonicalize both the queried file path and repo root before deriving a Windows repo-relative path
  • add a Windows regression test that calls file_status() with a canonicalized file path

Why

Historical Windows runs for #160 still failed with left: Clean, right: Untracked on the GitHub runner, while local Windows repro remained inconsistent. This keeps the fix scoped to the remaining path-shape mismatch and preserves the earlier fallback logic.

Validation

  • cargo test --locked --bin ferrite vcs::git::tests::test_git_service_untracked_file -- --exact --nocapture
  • cargo test --locked --bin ferrite vcs::git::tests:: -- --nocapture
  • cargo check --locked --bin ferrite
  • git diff --check -- src/vcs/git.rs

All cargo commands were run with:

  • CARGO_BUILD_JOBS=1
  • CARGO_TARGET_DIR=E:\Zero_Base\sumi_os\playground\Ferrite-windows-git-untracked-fix\target

Notes

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 456e4636-0fb3-433e-a7cc-dfd0024aad94

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@OlaProeis
OlaProeis merged commit 2624753 into OlaProeis:0.3.1-experimental Jun 19, 2026
4 checks passed
@OlaProeis

Copy link
Copy Markdown
Owner

Merged into 0.3.1-experimental locally and pushed. Thanks for the follow-up fix and for getting Windows CI green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants