Skip to content

fix(OK-99): 일기 작성 API 수정#62

Merged
rhrudska987 merged 3 commits into
developfrom
fix/OK-99
Apr 30, 2025
Merged

fix(OK-99): 일기 작성 API 수정#62
rhrudska987 merged 3 commits into
developfrom
fix/OK-99

Conversation

@rhrudska987
Copy link
Copy Markdown
Collaborator

관련 이슈

https://onehunnit.atlassian.net/browse/OK-99

작업 내용

  • 사진이 없어도 일기 작성 가능하게 변경
  • 일기의 날씨 필드 타입을 enum으로 변경(SUNNY, CLOUDY, RAINY, SNOWY, FOG)

참고사항

3월 25일 회의 요청사항

- 사진이 없어도 일기 작성 가능하게 변경
- 날씨 필드 탕입을 enum으로 변경(SUNNY, CLOUDY, RAINY, SNOWY, FOG)
@rhrudska987 rhrudska987 self-assigned this Apr 28, 2025
@rhrudska987 rhrudska987 requested a review from sjsjsj1246 as a code owner April 28, 2025 08:54
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2025

Unit Test Results

19 tests   15 ✔️  1s ⏱️
  7 suites    4 💤
  7 files      0

Results for commit 3b14973.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Member

@sjsjsj1246 sjsjsj1246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하나만 수정해주세요

private List<DiaryContentDto> contents;

@Schema(description = "날씨")
@Schema(description = "날씨(SUNNY, CLOUDY, RAINY, SNOWY, FOG")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

) 괄호 위치가 잘못된 것 같습니다.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵넵

- DiaryRequestDto 괄호 위치 해결
Copy link
Copy Markdown
Member

@sjsjsj1246 sjsjsj1246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rhrudska987 rhrudska987 merged commit 9257a16 into develop Apr 30, 2025
4 checks passed
@rhrudska987 rhrudska987 deleted the fix/OK-99 branch April 30, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants