fix(OK-108): 디바이스 토큰 저장 API 수정#63
Merged
Merged
Conversation
- NotificationRequestDto 생성자 추가 - 환자 ID 조회 API 추가
hyorish03
reviewed
May 2, 2025
Member
hyorish03
left a comment
hyorish03
left a comment
There was a problem hiding this comment.
고생 많으셨습니다 ! 리뷰 하나만 확인 부탁드립니다 :)
|
|
||
| @Operation(summary = "환자 Id 조회") | ||
| @GetMapping("/id") | ||
| public ResponseDto<PatientResponseDto.Id> getCaregiverId(@AuthenticationPrincipal AccountDetails accountDetails) { |
Member
There was a problem hiding this comment.
❓ 이해하기 어려운 부분에 대한 질문
@rhrudska987
제가 잘 몰라서 그러는데.. 환자 ID 조회면 getPatientId라고 네이밍 짓는게 맞을 것 같은데 getCaregiverId라고 되어있어서요 ..!
혹시 어떻게 생각하시나요 ? 😅
hyorish03
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
https://onehunnit.atlassian.net/browse/OK-108
작업 내용
참고사항