Repository navigation
Run golangci-lint v2 in CI to match local lint - #27
Merged
Merged
Conversation
golangci-lint-action@v6 only installs golangci-lint v1, so 'latest' resolved to v1.64.8 while local 'make lint' runs v2, which enables more staticcheck checks by default. CI passed code that failed locally. Move to action v9, pin v2.12.2, and declare the v2 config format.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golangci/golangci-lint-action@v6withversion: latest. Action v6 only supports golangci-lint v1, so CI installed v1.64.8. Localmake lintruns v2, which turns on morestaticcheckchecks by default (e.g. QF1012). As a result, CI passed code that failedmake lintlocally..golangci.yml(version: "2") to declare the config format. Default linters are unchanged.Test plan
make lintwith golangci-lint v2.12.2 on this branch: 0 issues (the QF1012 findings were already fixed onmainby Fix/include default branch for session category switch #25)