Skip to content

Remove unused TWILIO_ACCOUNT_SID / TWILIO_AUTH_TOKEN from docs - #28

Merged
aaronbrethorst merged 1 commit into
mainfrom
remove-unused-twilio-credentials
Oct 18, 2026
Merged

aaronbrethorst merged 1 commit into
mainfrom
remove-unused-twilio-credentials

Conversation

@aaronbrethorst

@aaronbrethorst aaronbrethorst commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Removes TWILIO_ACCOUNT_SID and TWILIO_AUTH_TOKEN from .env.example, the README config table and example, and CLAUDE.md.
  • No code has ever read them. None of the 158 commits on any branch has Go code that reads either variable (checked with git log -G'Getenv\("TWILIO' and git grep across every revision). They came from project-plan.md in the first commit (b9663ac, 2025-06-13), which listed them under "Twilio (for outbound functionality)". That feature was never defined or built. The plan was deleted in 93e6965, but the variables stayed in the docs.
  • The app answers webhooks with TwiML. The twilio-go dependency is used only for its twiml XML builder, not the REST client, so the app needs no Twilio credentials. Listing them encouraged operators (including OBACloud's template) to copy the account's auth token, which has full control of the account, into every deployment.

Test plan

  • git grep TWILIO_ outside docs/superpowers/** returns nothing
  • make test passes (docs-only change)

Review notes

  • The plan doc's "Validate Twilio signatures" item is the one real future use for the auth token, and it was never implemented. If it's added, the deployer should inject the token; it shouldn't go back into the docs as an optional setting.
  • Companion: OneBusAway/obacloud#1171 removes the same fields from its Twilio config template.

Summary by CodeRabbit

  • Documentation
    • Removed the Twilio account SID and auth token from the environment-variable examples and configuration guidance in the README, CLAUDE.md, and .env.example. These credentials are no longer listed in the project’s setup documentation.

No code in this repo has ever read either variable. They came from the
original project plan's 'outbound functionality' placeholder, which was
never defined or built; the app answers webhooks with TWiML and needs no
Twilio credentials. Listing them invites operators to copy the account's
auth token into every deployment for no benefit.
@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4b4512c5-ab09-4966-a47e-6b29a91fd575
📥 Commits

Reviewing files that changed from the base of the PR and between 3440bcc and 45566a8.

📒 Files selected for processing: 3
  • .env.example
  • CLAUDE.md
  • README.md
💤 Files with no reviewable changes: 3
  • .env.example
  • CLAUDE.md
  • README.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The .env.example, README.md, and CLAUDE.md no longer include TWILIO_ACCOUNT_SID or TWILIO_AUTH_TOKEN environment-variable entries.

Changes: Twilio environment-variable references

Layer / File(s) Summary
Remove Twilio environment-variable references
.env.example, README.md, CLAUDE.md
Removed the Twilio account SID and auth token from the environment example, README configuration table and example, and CLAUDE.md documentation.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 45566

The application does not require the removed Twilio credentials for its supported startup or webhook workflows. The documentation change is ready to merge after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing the unused Twilio environment variables from project documentation.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aaronbrethorst
aaronbrethorst merged commit 6c7ebfa into main Oct 18, 2026
4 checks passed
@aaronbrethorst
aaronbrethorst deleted the remove-unused-twilio-credentials branch October 18, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant