Repository navigation
chore: [SDK-5586] use com.onesignal.sdkdemo identifiers - #63
Draft
fadi-george wants to merge 1 commit into
Draft
fadi-george wants to merge 1 commit into
fadi-george wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fadi-george
marked this pull request as draft
October 22, 2026 00:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switch sdk-shared to the new demo identifiers
com.onesignal.sdkdemo(.NSE,.LA,group.com.onesignal.sdkdemo.onesignal). iOS demo signing is moving to the OneSignal, Inc. Apple team, wherecom.onesignal.exampleisn't available.Part of SDK-5585.
Details
generate_profiles.ts/download_profiles.ts: new bundle IDs; header documents the required capabilities per ID (.LAneeds none) and the API key requirement.setup-ios-demo-codesigningaction: bundle ID defaults updated.wdio.android.conf.ts,run-local/config.sh(incl. DotNet APK name),.env.example, scripts README use the new ID.tests/helpers/app.tsnow honorsBUNDLE_IDlike the wdio configs do.demo/build.md,demo/adjust.md: new identifiers.Breaking for consumers on
@main: SDK repos whose demos still usecom.onesignal.examplewill fail iOS/Android e2e after this merges. Until their demo is renamed, a repo can pass the old bundle IDs tosetup-ios-demo-codesigningand setBUNDLE_ID=com.onesignal.example. Merge alongside or after the demo repo renames.Testing:
vp check(0 errors),tsc --noEmit,bash -non run-local config. No e2e run; requires the new signing secrets.🤖 Generated with Claude Code