GDB-13418 sync repository deletion/creation from another tab#2522
Draft
plamen-yordanov wants to merge 1 commit intomasterfrom
Draft
GDB-13418 sync repository deletion/creation from another tab#2522plamen-yordanov wants to merge 1 commit intomasterfrom
plamen-yordanov wants to merge 1 commit intomasterfrom
Conversation
## What Implement synchronization of repository deletion/creation across different tabs ## Why Because currently there is no such synchronization. When creating/deleting repositories, the changes are not reflected in other tabs from the same origin ## How - Added a `BroadcastService` to send `BroadcastChannel` messages to other browser contexts - Added `broadcast-message` as a unified model of the message to be sent - Added a subscription in the main `controller.js`, which listens for `MessageType.REPOSITORIES_UPDATED` and triggers `$repositories.init()` - Added event dispatch on create/delete repository actions ## Testing n/a
|
Collaborator
|
@plamen-yordanov Wait with this change until Monday please. It turns out to be a feature implementation instead of bugfix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implement synchronization of repository deletion/creation across different tabs
Why
Because currently there is no such synchronization. When creating/deleting repositories, the changes are not reflected in other tabs from the same origin.
How
BroadcastServiceto sendBroadcastChannelmessages to other browser contextsbroadcast-messageas a unified model of the message to be sentcontroller.js, which listens forMessageType.REPOSITORIES_UPDATEDand triggers$repositories.init()Testing
n/a
Screenshots
Checklist