Draft
Conversation
## What The radio button circle was not centered. ## Why The radio buttons were custom-styled to look consistent across all browsers. Centering was done using margins, which can cause misalignment because different browsers calculate margins differently. ## How Changed the radio button to use a flex container and applied horizontal and vertical centering.
|
yordanalexandrov
approved these changes
Jan 28, 2026
|
|
||
| input[type="radio"]:checked::after { | ||
| content: ""; | ||
| display: block; |
Collaborator
There was a problem hiding this comment.
hmm, I shall check this out, but I though that in order to give the content some width it must have display block or whatever but not inline or default.
Collaborator
There was a problem hiding this comment.
Ahh I see it now. It's the parent that have display:flex and causing the children to become flex items behaving like block elements.
Collaborator
|
Radio buttons doesn't look OK to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The radio button circle was not centered.
Why
The radio buttons were custom-styled to look consistent across all browsers. Centering was done using margins, which can cause misalignment because different browsers calculate margins differently.
How
Changed the radio button to use a flex container and applied horizontal and vertical centering.
Screenshots
Checklist