GDB-13688 support repositories from remote locations#2691
Draft
svilenvelikov wants to merge 10 commits into3.3from
Draft
GDB-13688 support repositories from remote locations#2691svilenvelikov wants to merge 10 commits into3.3from
svilenvelikov wants to merge 10 commits into3.3from
Conversation
… combined string containing the location if any. For example, if there is a location property, the parameter becomes in format like this repositoryId=http://host:port/repositories/repoId and if there is no location then it is just repositoryId=repoId
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables support for repositories from remote locations by modifying how repository identifiers are handled in URL parameters. The change allows repository identifiers to include location information in the format http://host:port/repositories/repoId when a location exists, or just repoId when no location is specified.
Changes:
- Added
getRepositoryIdentifier()method to theRepositorymodel to generate location-aware identifiers - Added utility methods to
RepositoryServicefor parsing repository URLs and getting repository identifiers - Updated all code that constructs repository ID URL parameters to use the new
getRepositoryIdentifier()method instead of directly accessing theidproperty
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/api/src/models/repositories/repository.ts | Adds getRepositoryIdentifier() method to generate location-aware repository identifiers |
| packages/api/src/services/repository/repository.service.ts | Adds parseRepositoryUrl() and getRepositoryIdentifier() utility methods for handling repository identifiers |
| packages/shared-components/src/components/onto-navbar/onto-navbar.tsx | Updates navbar to use new repository identifier method |
| packages/legacy-workbench/src/js/angular/rest/mappers/sparql-template-mapper.js | Updates SPARQL template mapper to use new repository identifier method |
| packages/legacy-workbench/src/js/angular/graphexplore/controllers/graphs-visualizations.controller.js | Updates graph visualization controller to use new repository identifier method |
| packages/legacy-workbench/src/js/angular/export/controllers.js | Updates export controller to use new repository identifier method |
| packages/legacy-workbench/src/js/angular/controllers.js | Updates main controller with URL parsing logic and repository identifier handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…s expected to update urk if current active repo id is different that the one provided with the url
yordanalexandrov
force-pushed
the
GDB-13688-support-repositories-from-remote-locations
branch
from
6205410 to
8d05428
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Changing repositoryId url parameter value from plain repository id to combined string containing the location if any. For example, if there is a location property, the parameter becomes in format like this repositoryId=http://host:port/repositories/repoId and if there is no location then it is just repositoryId=repoId
Why
How
Testing
Screenshots
Checklist