add new problem: CossineAnnealingLr learning rate scheduler #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komaksym
changed the title
moe18
reviewed
Jul 4, 2025
Collaborator
moe18
left a comment
moe18
left a comment
There was a problem hiding this comment.
there was an issue with the test results
| }, | ||
| { | ||
| "test": "import math\nscheduler = CosineAnnealingLRScheduler(initial_lr=0.1, T_max=10, min_lr=0.001)\nprint(f\"{scheduler.get_lr(epoch=2):.4f}\")", | ||
| "expected_output": "0.0818" |
Collaborator
There was a problem hiding this comment.
I got this from the solution
0.0905
Contributor
Author
There was a problem hiding this comment.
Yup, true, will fix
| }, | ||
| { | ||
| "test": "import math\nscheduler = CosineAnnealingLRScheduler(initial_lr=0.1, T_max=10, min_lr=0.001)\nprint(f\"{scheduler.get_lr(epoch=7):.4f}\")", | ||
| "expected_output": "0.0275" |
Collaborator
There was a problem hiding this comment.
0.0214 I got this from the solution
komaksym
force-pushed
the
add_new_problem_CosineAnnealingLR
branch
from
b92a449 to
564964d
Compare
Contributor
Author
|
Fixed the test cases, changed the question number and force pushed changed commit message to avoid matching github issue refs |
komaksym
force-pushed
the
add_new_problem_CosineAnnealingLR
branch
from
564964d to
20d0fe4
Compare
moe18
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #478