refactor(typescript-fetch): centralize date type handling in TypeScriptFetchClientCodegen - #24715
Open
Mattias-Sehlstedt wants to merge 1 commit into
Open
Conversation
…ptFetchClientCodegen
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several incentives to support better and consistent date handling for
typescript-fetch#24714, #24637. I saw that they had to define the same thing over and over again when they were technically referring to the exact same thing.I have gathered the definition in a single location so that any further change will be easier to follow and understand.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Centralizes date type handling in TypeScriptFetchClientCodegen to keep
date/DateTimemapping consistent and easier to maintain. No behavior change: bothdateandDateTimestill generate TypeScriptDate, and type checks use the new helpers.dateandDateTimenow references constants and shared helpers (isDateType,isDateTimeType) instead of inline"Date"comparisons.Written for commit bc4ca5d. Summary will update on new commits.