Skip to content

fix(prompt): restrict prompt template paths to the workspace prompt/ directory - #586

Open
AyhamJo7 wants to merge 1 commit into
OpenBMB:mainfrom
AyhamJo7:fix/520-restrict-prompt-template-directory
Open

AyhamJo7 wants to merge 1 commit into
OpenBMB:mainfrom
AyhamJo7:fix/520-restrict-prompt-template-directory

Conversation

@AyhamJo7

Copy link
Copy Markdown

Summary

Fixes #520

_validate_template_path in servers/prompt/src/prompt.py previously checked only whether ".." in str(path), allowing arbitrary absolute paths (such as /etc/passwd) or symlinks escaping prompt/ to be loaded and rendered by MCP prompt endpoints.

Changes

  • Resolve relative template paths (both prompt/<file>.jinja and <file>.jinja) against the repository prompt/ directory (_PROMPTS_DIR).
  • Require resolved.is_relative_to(_PROMPTS_DIR) and a valid Jinja template extension (.jinja, .jinja2, .j2), matching ToolWorkspace._prompt in ui/backend/agent_workspace.py.
  • Add unit tests in tests/servers/prompt/test_prompt_path_validation.py covering workspace relative/absolute prompt paths, arbitrary absolute paths, traversal paths, non-Jinja files, and symlinks pointing outside prompt/.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SECURITY] Arbitrary file read via absolute path in MCP prompt qa_rag_boxed_multiple_choice (CWE-22, CVSS 7.5)

1 participant