Repository navigation
fix: normalize timeframe case for alert poll interval - #293
Merged
brokermr810 merged 1 commit intoOct 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_poll_secondsin the indicator signal alert service only had uppercase keys (1H,4H,1D,1W), but timeframes are stored as entered and the create path defaults to"1h". So1h,4h,1dand1walerts all fell through to the 120s default, and3m(added in #87) had no entry at all.Related issue
Changes
normalize_frequency()and use lowercase keys to match.3minterval of 25s, between the1mand5mvalues.Test plan
docker compose up -d --buildpython -m pytest tests/test_indicator_signal_alerts.py -qpasses (28 tests). Without the fix, the new test fails for3m,4h,1dand1w.