VMRay-Platform new integration #5427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @romain-filigran |
romain-filigran
requested changes
Jan 7, 2026
| @@ -0,0 +1,21 @@ | |||
| { | |||
| "title": "VMRay", | |||
Member
There was a problem hiding this comment.
Hey @moin-loginsoft : Can you please change to "VMRay Platform"
| @@ -0,0 +1,21 @@ | |||
| { | |||
| "title": "VMRay", | |||
| "slug": "VMRay", | |||
Member
There was a problem hiding this comment.
Hey @moin-loginsoft : Can you please change to "vmray-platform"
romain-filigran
requested changes
Jan 7, 2026
| "title": "VMRay", | ||
| "slug": "VMRay", | ||
| "title": "VMRay Platform", | ||
| "slug": "VMRay Platform", |
Member
There was a problem hiding this comment.
The slug must be lowercase and without spaces, and must match the connector folder name. Can you replace it with "vmray-platform". Thank you
Contributor
Author
There was a problem hiding this comment.
Thanks. My bad. updated to vmray-platform :)
romain-filigran
approved these changes
Jan 7, 2026
Member
romain-filigran
left a comment
romain-filigran
left a comment
There was a problem hiding this comment.
Thank you @moin-loginsoft for the coontribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Integration
I consider the submitted work as finished
I have signed my commits using GPG key.
I tested the code for its functionality using different use cases
I added/update the relevant documentation (either on github or on notion)
Where necessary I refactored code to improve the overall quality
[vmray-platform] Create the connector #5571