ec: test-win: Remove test KMDF driver - #169
Merged
Merged
Conversation
The ectest.sys driver has moved to the odp-windows-drivers repo. Delete the kmdf/ sources and repoint docs; keep inc/ectest.h since lib/exe still use its IOCTL contract at runtime. Assisted-by: GitHub Copilot:claude-opus-4.8
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the Windows KMDF ectest.sys test driver sources/project from ec/test-win and updates the surrounding documentation to point consumers at the new driver location in odp-windows-drivers, while keeping the shared IOCTL/header contract in this repo.
Changes:
- Delete the
ec/test-win/kmdf/KMDF driver source files and theectest_kmdf.vcxproj. - Update
ec/test-win,ec/test-cli, andec/test-tuidocumentation to reference the driver’s new repository/path. - Remove stale
kmdfbuild output ignore entries fromec/test-tui/.gitignoreand clarify the driver GUID comment inec/test-lib.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ec/test-win/README.md | Updates build/install docs to reference ectest.sys in odp-windows-drivers and removes local KMDF build steps. |
| ec/test-win/kmdf/trace.h | Removes KMDF driver tracing header (driver code moved out of this repo). |
| ec/test-win/kmdf/queue.h | Removes KMDF driver queue header (driver code moved out of this repo). |
| ec/test-win/kmdf/queue.c | Removes KMDF driver request handling implementation (driver code moved out of this repo). |
| ec/test-win/kmdf/public.h | Removes KMDF shared declarations previously kept with the driver (driver code moved out of this repo). |
| ec/test-win/kmdf/ffainterface.h | Removes FF-A interface header shipped with the KMDF driver (driver code moved out of this repo). |
| ec/test-win/kmdf/ffa.h | Removes FF-A HAL interface header shipped with the KMDF driver (driver code moved out of this repo). |
| ec/test-win/kmdf/ectest_kmdf.vcxproj | Removes the KMDF driver Visual Studio project. |
| ec/test-win/kmdf/driver.h | Removes the KMDF driver header (driver code moved out of this repo). |
| ec/test-win/kmdf/driver.c | Removes the KMDF driver entry/dispatch implementation (driver code moved out of this repo). |
| ec/test-win/kmdf/device.h | Removes the KMDF device context/creation header (driver code moved out of this repo). |
| ec/test-win/kmdf/device.c | Removes KMDF device creation and interface registration logic (driver code moved out of this repo). |
| ec/test-tui/README.md | Updates Windows “local” source note to point at odp-windows-drivers for ectest.sys. |
| ec/test-tui/.gitignore | Removes stale ignores for kmdf outputs that no longer exist in this repo. |
| ec/test-lib/src/acpi.rs | Updates the GUID comment to reference the driver’s new home. |
| ec/test-cli/README.md | Updates Windows “local” source note to point at odp-windows-drivers for ectest.sys. |
philgweber
approved these changes
Aug 4, 2026
williampMSFT
approved these changes
Aug 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 17 changed files in this pull request and generated no new comments.
Suppressed comments (1)
ec/test-win/README.md:44
- The compilation section builds ARM64 Release, but the install copy instructions still reference a
Debugoutput path forectest.exe. Since this PR updates the driver location line in the same copy list, it’s a good opportunity to make the referenced output paths consistent with the documented build commands (otherwise readers may copy the wrong binaries).
Copy the following files to a thumbdrive or location on the target:
ec\test-win\exe\arm64\Debug\ectest.exe
\ectest_kmdf*
</details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the ectest KMDF driver from here since another PR has opened to move it over to odp-windows-drivers (see: OpenDevicePartnership/odp-windows-drivers#5).
Depends on #161 to fix the cargo deny issue.
Related: OpenDevicePartnership/odp-platform-qemu-arm-virt#118