Skip to content

ec: test-win: Remove test KMDF driver - #169

Merged
kurtjd merged 2 commits into
OpenDevicePartnership:mainfrom
kurtjd:remove-ectest-driver
Aug 5, 2026
Merged

ec: test-win: Remove test KMDF driver#169
kurtjd merged 2 commits into
OpenDevicePartnership:mainfrom
kurtjd:remove-ectest-driver

Conversation

@kurtjd

@kurtjd kurtjd commented Aug 4, 2026

Copy link
Copy Markdown
Member

Remove the ectest KMDF driver from here since another PR has opened to move it over to odp-windows-drivers (see: OpenDevicePartnership/odp-windows-drivers#5).

Depends on #161 to fix the cargo deny issue.

Related: OpenDevicePartnership/odp-platform-qemu-arm-virt#118

The ectest.sys driver has moved to the odp-windows-drivers repo. Delete the kmdf/ sources and repoint docs; keep inc/ectest.h since lib/exe still use its IOCTL contract at runtime.

Assisted-by: GitHub Copilot:claude-opus-4.8
@kurtjd kurtjd self-assigned this Aug 4, 2026
Copilot AI lite review requested due to automatic review settings August 4, 2026 20:09
@kurtjd
kurtjd requested a review from a team as a code owner August 4, 2026 20:09
@kurtjd kurtjd changed the title ec: Remove test KMDF driver from test-win ec: test-win: Remove test KMDF driver from test-win Aug 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the Windows KMDF ectest.sys test driver sources/project from ec/test-win and updates the surrounding documentation to point consumers at the new driver location in odp-windows-drivers, while keeping the shared IOCTL/header contract in this repo.

Changes:

  • Delete the ec/test-win/kmdf/ KMDF driver source files and the ectest_kmdf.vcxproj.
  • Update ec/test-win, ec/test-cli, and ec/test-tui documentation to reference the driver’s new repository/path.
  • Remove stale kmdf build output ignore entries from ec/test-tui/.gitignore and clarify the driver GUID comment in ec/test-lib.

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ec/test-win/README.md Updates build/install docs to reference ectest.sys in odp-windows-drivers and removes local KMDF build steps.
ec/test-win/kmdf/trace.h Removes KMDF driver tracing header (driver code moved out of this repo).
ec/test-win/kmdf/queue.h Removes KMDF driver queue header (driver code moved out of this repo).
ec/test-win/kmdf/queue.c Removes KMDF driver request handling implementation (driver code moved out of this repo).
ec/test-win/kmdf/public.h Removes KMDF shared declarations previously kept with the driver (driver code moved out of this repo).
ec/test-win/kmdf/ffainterface.h Removes FF-A interface header shipped with the KMDF driver (driver code moved out of this repo).
ec/test-win/kmdf/ffa.h Removes FF-A HAL interface header shipped with the KMDF driver (driver code moved out of this repo).
ec/test-win/kmdf/ectest_kmdf.vcxproj Removes the KMDF driver Visual Studio project.
ec/test-win/kmdf/driver.h Removes the KMDF driver header (driver code moved out of this repo).
ec/test-win/kmdf/driver.c Removes the KMDF driver entry/dispatch implementation (driver code moved out of this repo).
ec/test-win/kmdf/device.h Removes the KMDF device context/creation header (driver code moved out of this repo).
ec/test-win/kmdf/device.c Removes KMDF device creation and interface registration logic (driver code moved out of this repo).
ec/test-tui/README.md Updates Windows “local” source note to point at odp-windows-drivers for ectest.sys.
ec/test-tui/.gitignore Removes stale ignores for kmdf outputs that no longer exist in this repo.
ec/test-lib/src/acpi.rs Updates the GUID comment to reference the driver’s new home.
ec/test-cli/README.md Updates Windows “local” source note to point at odp-windows-drivers for ectest.sys.

Comment thread ec/test-win/README.md
@kurtjd kurtjd changed the title ec: test-win: Remove test KMDF driver from test-win ec: test-win: Remove test KMDF driver Aug 4, 2026
Copilot AI review requested due to automatic review settings August 5, 2026 19:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated no new comments.

Suppressed comments (1)

ec/test-win/README.md:44

  • The compilation section builds ARM64 Release, but the install copy instructions still reference a Debug output path for ectest.exe. Since this PR updates the driver location line in the same copy list, it’s a good opportunity to make the referenced output paths consistent with the documented build commands (otherwise readers may copy the wrong binaries).
Copy the following files to a thumbdrive or location on the target:

ec\test-win\exe\arm64\Debug\ectest.exe
\ectest_kmdf*

</details>

@kurtjd
kurtjd merged commit af7c74a into OpenDevicePartnership:main Aug 5, 2026
25 checks passed
@kurtjd
kurtjd deleted the remove-ectest-driver branch August 5, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants