Implement 7-color support to BLE tester - #90
Open
TheAppleFreak wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits add the necessary schema changes and dithering patches to support 7 color displays (BW, yellow, red, blue, green, and orange).
One thing to note is these are implemented against the behavior for 7 color displays in py-opendisplay. From what I've read, ACeP panels might have a different color order that will need to be changed in both projects when tested against real hardware. I don't have that kind of hardware, so I can't validate that at this time. It shouldn't be too hard to change, though; it's just one line of code that'd need to be changed in ble-common.