Skip to content

gsheets: Update input data format and allow for multiple range updates#1655

Open
hunterachieng wants to merge 11 commits into
mainfrom
feature/1476-gsheets-range-update
Open

gsheets: Update input data format and allow for multiple range updates#1655
hunterachieng wants to merge 11 commits into
mainfrom
feature/1476-gsheets-range-update

Conversation

@hunterachieng
Copy link
Copy Markdown
Contributor

@hunterachieng hunterachieng commented Apr 24, 2026

Summary

Updated appendValues(), batchUpdateValues(), and getValues() to use positional arguments instead of a single params object.

Callback parameter has been removed from appendValues(), batchUpdateValues(), and getValues() in favor of a promise-based API.

Supporting array of data in appendValues(id, data = [{}], options).

Fixes #1476 #1656

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • If this PR includes breaking changes, do we need to update any jobs in
    production? Is it safe to release?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
@hunterachieng hunterachieng requested review from mtuchi and removed request for mtuchi April 24, 2026 21:15
Comment thread packages/googlesheets/src/Adaptor.js Outdated
Copy link
Copy Markdown
Collaborator

@mtuchi mtuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have asked joe, for his opinion on new signature
batchUpdateValues(sheetId, data = [{range, values}], options = {valueInputOption})

If he agrees i think, we should update appendValues as well and remove support for callback in getValues()

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Comment thread .changeset/new-things-change.md
Comment thread packages/googlesheets/src/Adaptor.js Outdated
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
@hunterachieng hunterachieng requested a review from mtuchi April 27, 2026 10:42
Comment thread packages/googlesheets/src/Adaptor.js
@hunterachieng hunterachieng requested a review from mtuchi April 27, 2026 11:54
Comment thread packages/googlesheets/test/index.js
Copy link
Copy Markdown
Collaborator

@mtuchi mtuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hunterachieng i think the changes are looking good, can you tidy up two things

  • Create an issue supporting array of data in appendValues(id, data = [{}], options) to match what we have in batchUpdateValues
  • Clean up PR description and title to match the changes and don't forget to update the review checklist as well

@hunterachieng hunterachieng changed the title Feature/1476 gsheets range update gsheets: Update input data format and allow for multiple range updates Apr 27, 2026
@hunterachieng hunterachieng requested a review from mtuchi April 27, 2026 13:17
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Comment thread packages/googlesheets/src/Adaptor.js Outdated
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Comment thread packages/googlesheets/src/Adaptor.js
Comment thread packages/googlesheets/src/Adaptor.js Outdated
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
@hunterachieng hunterachieng requested a review from mtuchi May 28, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

GoogleSheets adaptor should support multi-range update and throttling

3 participants