gsheets: Update input data format and allow for multiple range updates#1655
Open
hunterachieng wants to merge 11 commits into
Open
gsheets: Update input data format and allow for multiple range updates#1655hunterachieng wants to merge 11 commits into
hunterachieng wants to merge 11 commits into
Conversation
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
mtuchi
reviewed
Apr 27, 2026
mtuchi
requested changes
Apr 27, 2026
Collaborator
mtuchi
left a comment
There was a problem hiding this comment.
I have asked joe, for his opinion on new signature
batchUpdateValues(sheetId, data = [{range, values}], options = {valueInputOption})
If he agrees i think, we should update appendValues as well and remove support for callback in getValues()
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
mtuchi
reviewed
Apr 27, 2026
mtuchi
reviewed
Apr 27, 2026
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
mtuchi
reviewed
Apr 27, 2026
mtuchi
reviewed
Apr 27, 2026
mtuchi
reviewed
Apr 27, 2026
Collaborator
mtuchi
left a comment
There was a problem hiding this comment.
@hunterachieng i think the changes are looking good, can you tidy up two things
- Create an issue supporting array of data in
appendValues(id, data = [{}], options)to match what we have inbatchUpdateValues - Clean up PR description and title to match the changes and don't forget to update the review checklist as well
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
mtuchi
reviewed
Apr 27, 2026
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
mtuchi
reviewed
May 25, 2026
mtuchi
reviewed
May 25, 2026
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated
appendValues(),batchUpdateValues(), andgetValues()to use positional arguments instead of a single params object.Callback parameter has been removed from
appendValues(),batchUpdateValues(), andgetValues()in favor of a promise-based API.Supporting array of data in appendValues(id, data = [{}], options).
Fixes #1476 #1656
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
production? Is it safe to release?
dev only changes don't need a changeset.