Types rethink#1408
Closed
josephjclark wants to merge 5 commits into
Closed
Conversation
josephjclark
changed the base branch from
main
to
support-trigger-webhook-response
josephjclark
commented
May 14, 2026
| dataclip_retention_period?: string | null; | ||
| } | ||
|
|
||
| export interface ProjectSpec |
Collaborator
Author
There was a problem hiding this comment.
this doens't work for me at all. It's too hard to reconcile these types right now, sadly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rethinking types a bit in the v1 deploy package, which I don't like to touch
But we have too much type duplication between lexicon and deploy. Claude has fixed it for me, I think
This will help ensure better type consistency